Sidekiq to solid queue migration #1871
Conversation
apoorv1316
commented
Jul 2, 2024
•
apoorv1316
commented
- Migrated from sidekiq to solid queue for jobs.
There was a problem hiding this comment.
Great work @apoorv1316 🎉,
I've added some minor comments, lemme know your thoughts on that.
| gem "mission_control-jobs" | ||
| gem "solid_queue", "~> 0.3" |
There was a problem hiding this comment.
Add proper description for these two gems
| @@ -1,2 +1 @@ | |||
| web: bundle exec puma -t 5:5 -p ${PORT:-3000} -e ${RACK_ENV:-production} | |||
| worker: bundle exec sidekiq -e production -C config/sidekiq.yml | |||
There was a problem hiding this comment.
don't we wanna run the solidqueue worker on production?
There was a problem hiding this comment.
I've added it in fly.production.toml . Do we still need to add it here?
| @@ -0,0 +1,18 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class MissionControlController < ApplicationController | |||
There was a problem hiding this comment.
can you also add a test for this controller?
| @@ -209,7 +206,6 @@ group :test, :ci do | |||
| # Strategies for cleaning databases in Ruby. | |||
| gem "database_cleaner", "~> 2.0" | |||
| gem "hash_dot" | |||
| gem "rspec-sidekiq", git: "https://github.com/wspurgin/rspec-sidekiq", branch: "main" | |||
There was a problem hiding this comment.
Did you noticed any issue on running the jobs on test?
There was a problem hiding this comment.
2 tests were failing after removing this gem because they were using the matchers from this gem. Now I am using matcher from rspec-rails for those tests.
| @@ -27,13 +27,6 @@ GOOGLE_OAUTH_CLIENT_SECRET='google-oauth-client-secret' | |||
| # Application Monitoring | |||
| NEW_RELIC_LICENSE_KEY='replace with newrelic licence key' | |||
|
|
|||
| # Redis url | |||
There was a problem hiding this comment.
Keep this until we are getting rid of Redis completely
