Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant API for Teams and Profile page #1854

Merged
merged 15 commits into from
Jun 26, 2024
Merged

Remove redundant API for Teams and Profile page #1854

merged 15 commits into from
Jun 26, 2024

Conversation

nisusam
Copy link
Contributor

@nisusam nisusam commented May 29, 2024 •
edited by Shruti-Apte
Loading

  • Fix Create component for Teams and Profile page #1852
  • Fix Image for team members are not saved #1857
  • Use the teams API instead of the profile API
  • Remove duplicate routes
  • Remove profile#show action
  • Add user id to Team Member API response
  • Fix typographical error
  • Remove removeAvatar and updateAvatar API from the profile
  • Fix the issue where the team member avatar is not persisting
  • Set headers with multipart/form-data content type
  • Remove duplicate success message for Image deleted successfully

Frontend Changes:

@nisusam nisusam requested a review from apoorv1316 May 29, 2024 14:32
@nisusam nisusam marked this pull request as ready for review May 30, 2024 10:03
Nishant Samel and others added 6 commits May 31, 2024 17:03
Remove duplicate routes
dea21ee
Remove removeAvatar and updateAvatar API from profile
819522c 
- Fix issue where team member avatar is not persisting
- Set headers with `multipart/form-data` content type
- Remove duplicate success message for `Image deleted successfully`
Merge branch 'develop' into remove_redundant_api
8c10369
Merge branch 'develop' into remove_redundant_api
86ee533
Update policies and respective specs
8b63cea
Common componet created for profile
49da64f
nisusam
nisusam commented Jun 19, 2024
View reviewed changes
app/javascript/src/components/Profile/Common/Container.tsx Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shruti-Apte delete if unused

@apoorv1316 apoorv1316 merged commit 4ce95d9 into develop Jun 26, 2024
1 check passed
@apoorv1316 apoorv1316 deleted the remove_redundant_api branch June 26, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

@akhilgkrishnan akhilgkrishnan Awaiting requested review from akhilgkrishnan

@prasanthchaduvula prasanthchaduvula Awaiting requested review from prasanthchaduvula

@Shruti-Apte Shruti-Apte Awaiting requested review from Shruti-Apte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image for team members are not saved Create component for Teams and Profile page
2 participants
@nisusam @apoorv1316