Skip to content

Commit

Permalink
Fixed holidays are not being shown after applying filters bug (#1799)
Browse files Browse the repository at this point in the history
  • Loading branch information
prasanthchaduvula authored Apr 10, 2024
1 parent 4426888 commit 2c11922
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions app/services/timeoff_entries/index_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@

module TimeoffEntries
class IndexService < ApplicationService
attr_reader :current_company, :current_user, :user_id, :year, :optional_timeoff_entries, :national_timeoff_entries,
:previous_year
attr_accessor :leave_balance
attr_reader :current_company, :current_user, :user_id, :year, :previous_year
attr_accessor :leave_balance, :optional_timeoff_entries, :national_timeoff_entries

def initialize(current_user, current_company, user_id, year)
@current_user = current_user
Expand Down Expand Up @@ -104,7 +103,7 @@ def calculate_holiday_balance

def calculate_national_holiday_balance(holiday)
total_national_holidays = holiday.holiday_infos.national.count
national_timeoff_entries = holiday.national_timeoff_entries.where(user: user_id)
@national_timeoff_entries = holiday.national_timeoff_entries.where(user: user_id)

national_holidays = {
id: "national",
Expand All @@ -123,7 +122,7 @@ def calculate_national_holiday_balance(holiday)
def calculate_optional_holiday_balance(holiday)
no_of_allowed_optional_holidays = holiday.no_of_allowed_optional_holidays
time_period_optional_holidays = holiday.time_period_optional_holidays
optional_timeoff_entries = holiday.optional_timeoff_entries.where(user: user_id)
@optional_timeoff_entries = holiday.optional_timeoff_entries.where(user: user_id)

total_optional_entries = TimeoffEntries::CalculateOptionalHolidayTimeoffEntriesService.new(
time_period_optional_holidays,
Expand Down

0 comments on commit 2c11922

Please sign in to comment.