Skip to content

Commit

Permalink
Merge pull request wintersrd#85 from s7clarke10/bug/fix_escaping_for_…
Browse files Browse the repository at this point in the history
…table_lsn_function

Passing in a non-escaped table to the lsn lookup function
  • Loading branch information
mjsqu authored Oct 9, 2024
2 parents d1c4540 + 61907ec commit b82bafb
Show file tree
Hide file tree
Showing 5 changed files with 88 additions and 77 deletions.
2 changes: 1 addition & 1 deletion .bumpversion.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 2.6.0
current_version = 2.6.1
parse = (?P<major>\d+)
\.(?P<minor>\d+)
\.(?P<patch>\d+)
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# tap-mssql 2.6.1 2024-10-09
* Resolving issue with call get the prior LSN number (passing in unescaped table).

# tap-mssql 2.6.0 2024-09-02
* Resolving issue LOG_BASED tables with special characters. Escaping the object
names with double quotes. Issue #74
Expand Down
156 changes: 82 additions & 74 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "tap-mssql"
version = "2.6.0"
version = "2.6.1"
description = "A pipelinewise compatible tap for connecting Microsoft SQL Server"
authors = ["Rob Winters <[email protected]>"]
license = "GNU Affero"
Expand Down
2 changes: 1 addition & 1 deletion tap_mssql/sync_strategies/log_based.py
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ def sync_table(mssql_conn, config, catalog_entry, state, columns, stream_version
).format(escaped_schema_name, escape_table_name)
)

lsn_range = get_lsn_available_range(mssql_conn, escaped_cdc_table)
lsn_range = get_lsn_available_range(mssql_conn, cdc_table)

if lsn_range[0] is not None: # Test to see if there are any change records to process
lsn_from = str(lsn_range[0].hex())
Expand Down

0 comments on commit b82bafb

Please sign in to comment.