Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Check* Hooks #963

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement Check* Hooks #963

wants to merge 2 commits into from

Conversation

JohanCorn
Copy link

  • CheckGameOver
  • CheckTimeLimit
  • CheckFragLimit
  • CheckMaxRounds
  • CheckWinLimit

@JohanCorn
Implement Check* Hooks
190ceec 
- CheckGameOver
- CheckTimeLimit
- CheckFragLimit
- CheckMaxRounds
- CheckWinLimit
@dystopm
Copy link
Contributor

dystopm commented May 25, 2024

Question, why are you declaring hook function as VFUNC?

@JohanCorn
Copy link
Author

Question, why are you declaring hook function as VFUNC?

I made a mistake, but thank you for pointing it out.

@JohanCorn JohanCorn marked this pull request as draft May 25, 2024 23:40
@dystopm dystopm mentioned this pull request Jun 1, 2024
Open
@JohanCorn
Copy link
Author

Question, why are you declaring hook function as VFUNC?

I have changed the VFUNC BOOL declarations to BOOL. However, I'm not sure if it is also necessary to change the bool type BOOL (int) as I did. Could you please review this aspect as well? Thank you!

@JohanCorn JohanCorn marked this pull request as ready for review June 11, 2024 08:41
@s1lentq s1lentq force-pushed the master branch 4 times, most recently from a363cba to 79cfd71 Compare July 14, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohanCorn @dystopm