Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various defuser fixes and code refactory #848

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

dystopm
Copy link
Contributor

@dystopm dystopm commented Jul 14, 2023

  • Fixed item_thighpack entity not spawning on CBasePlayer::Disappear (which shares logic with CBasePlayer::Killed). Fixed version deleted GiveNamedItem (reasonably) but nobody coded the entity spawning.
  • Fixed CCSPlayer::RemovePlayerItemEx not clearing ProgressBar HUD when removing defuser.
  • Ensuring m_bIsDefusing assignation whenever defuser is removed from player.
  • Defuser removal logic grouped into CBasePlayer::RemoveDefuser.
  • Some minor logic changes and unneeded code erase.

@dystopm
Copy link
Contributor Author

dystopm commented Jul 14, 2023

Just found RemoveDefuser is a function not present in original version so it gaves me room to not enclose some code in fix macros. Gonna check now

@dystopm dystopm marked this pull request as draft July 14, 2023 06:34
@dystopm dystopm changed the title Fix: Defuser not spawning on CBasePlayer::Disappear (plus code cleaning) Various defuser fixes and code refactory Jul 15, 2023
@dystopm dystopm marked this pull request as ready for review July 15, 2023 06:06
@s1lentq s1lentq merged commit facc2be into s1lentq:master Sep 5, 2023
4 checks passed
@dystopm dystopm deleted the defuser-code-clean branch October 11, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants