replace deprecated appdirs with platfromdirs fork #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1970 +/- ##
==========================================
+ Coverage 81.41% 81.62% +0.21%
==========================================
Files 193 197 +4
Lines 18636 19127 +491
Branches 4045 4206 +161
==========================================
+ Hits 15173 15613 +440
- Misses 3180 3220 +40
- Partials 283 294 +11 ☔ View full report in Codecov by Sentry. |
rytilahti
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
LGTM, thanks @a-detiste! The CI errors seem unrelated (even when caused by some lib upgrades) so I'll just merge this as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python3-appdirs is dead upstream[1] and its Debian maintainer has indicated
that it should not be included in trixie[2]. A recommended replacement is
python3-platformdirs[3], which is a fork of appdirs with a very similar API.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067997