Fix hardcoded lumi.gateway module path #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hardcoded 'path' broke when the gateway was moved from the main package to its own one under integrations/lumi/gateway.
Codecov Report
@@ Coverage Diff @@
## master #1794 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 192 192
Lines 18511 18511
Branches 4012 4012
=======================================
Hits 14939 14939
Misses 3295 3295
Partials 277 277
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I would not know of a better way to do this unfortunately.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hardcoded 'path' broke when the gateway was moved from the main package to its own one under integrations/lumi/gateway.
This should fix #1791 but is untested. @starkillerOG any ideas if there is a better way to do this besides hardcoding the path?