Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 SIM910 errors and add pin pydantic==^1 #1793

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

rytilahti
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #1793 (92ffd2c) into master (788df48) will increase coverage by 0.01%.
The diff coverage is 77.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1793      +/-   ##
==========================================
+ Coverage   80.69%   80.70%   +0.01%     
==========================================
  Files         192      192              
  Lines       18509    18510       +1     
  Branches     4010     4012       +2     
==========================================
+ Hits        14936    14939       +3     
+ Misses       3296     3294       -2     
  Partials      277      277              
Impacted Files Coverage Δ
miio/integrations/genericmiot/genericmiot.py 35.83% <0.00%> (ø)
...iio/integrations/lumi/gateway/devices/subdevice.py 33.14% <0.00%> (ø)
...o/integrations/roborock/vacuum/vacuumcontainers.py 83.29% <0.00%> (ø)
miio/integrations/roborock/vacuum/vacuum.py 62.45% <66.66%> (+0.06%) ⬆️
...integrations/cgllc/airmonitor/airqualitymonitor.py 83.76% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti
Copy link
Owner Author

Looks like the builds were failing on some win & mac combinations with the same error as discussed in python-poetry/poetry#7611 - also, the docs build was failing due as the code base is not pydantic v2 compatible at the moment, so this adds a pin to pydantic==^1.

@rytilahti rytilahti changed the title Fix flake8 SIM910 errors Fix flake8 SIM910 errors and add pin pydantic==^1 Jul 14, 2023
@rytilahti rytilahti merged commit d4ca76e into master Jul 14, 2023
16 checks passed
@rytilahti rytilahti deleted the fix/fix_flake8_sim910 branch July 14, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants