Fail early if trying to re-initialize descriptors

rytilahti · Mar 18, 2024 · 8edabc1 · 8edabc1
1 parent 4ffaf8e
commit 8edabc1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/miio/integrations/roborock/vacuum/vacuum.py b/miio/integrations/roborock/vacuum/vacuum.py
@@ -1066,10 +1066,12 @@ def _initialize_descriptors(self) -> None:
 
         Overridden to collect descriptors also from the update helper.
         """
-        if not self._initialized:
-            super()._initialize_descriptors()
-            res = self.status()
-            self._descriptors.descriptors_from_object(res)
+        if self._initialized:
+            return
+
+        super()._initialize_descriptors()
+        res = self.status()
+        self._descriptors.descriptors_from_object(res)
 
     @classmethod
     def get_device_group(cls):

diff --git a/miio/tests/test_device.py b/miio/tests/test_device.py
@@ -182,7 +182,9 @@ def test_supports_miot(mocker):
     assert d.supports_miot() is True
 
 
-@pytest.mark.parametrize("getter_name", ["actions", "settings", "sensors"])
+@pytest.mark.parametrize(
+    "getter_name", ["actions", "settings", "sensors", "descriptors"]
+)
 def test_cached_descriptors(getter_name, mocker, caplog):
     d = Device("127.0.0.1", "68ffffffffffffffffffffffffffffff")
     getter = getattr(d, getter_name)