Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for SkParagraph enable status, and pass it to the created engine #939

Open
wants to merge 3 commits into
base: minor
Choose a base branch
from
Open

Check for SkParagraph enable status, and pass it to the created engine #939

wants to merge 3 commits into from

Conversation

limitless-brain
Copy link

Check for SkParagraph enable status, and pass it to the created engine bug fix for the issue.

@ryanheise
Copy link
Owner

Thanks @limitless-brain for the PR. I'd definitely like to incorporate your contribution. I have left some comments regarding the diff that I'd like you to address before I can review it and see which lines you have actually changed. In addition to those two comments, there are many other locations where formatting changes should be undone before review.

@limitless-brain
Copy link
Author

Thanks @limitless-brain for the PR. I'd definitely like to incorporate your contribution. I have left some comments regarding the diff that I'd like you to address before I can review it and see which lines you have actually changed. In addition to those two comments, there are many other locations where formatting changes should be undone before review.

Noted, I will undo the formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanheise ryanheise ryanheise left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limitless-brain @ryanheise