Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Kindlegen download for Linux #14

Merged
merged 1 commit into from
Oct 31, 2015
Merged

fix Kindlegen download for Linux #14

merged 1 commit into from
Oct 31, 2015

Conversation

mojavelinux
Copy link

No description provided.

@mojavelinux
Copy link
Author

Not the prettiest way to fix it, but it gets the job done.

@mojavelinux
Copy link
Author

I also recommend renaming the folder to asciidoc-to-kf8-example. Using both epub3 and kf8 is redundant as kf8 is a (bastardized) type of epub3.

rwinch added a commit that referenced this pull request Oct 31, 2015
fix Kindlegen download for Linux
@rwinch rwinch merged commit c569582 into rwinch:kf8 Oct 31, 2015
@rwinch
Copy link
Owner

rwinch commented Oct 31, 2015

Thanks merged!

The reason I have it as epub3-kf8 is because eventually the sample will output both formats since that was what was requested in asciidoctor/issues/13

Does that change your opinion on the name? If so, what might you suggest?

@mojavelinux
Copy link
Author

Oh, I see. I was thinking you were creating a parallel project instead. Once you merge it upstream, I recommend simply using the name "epub3" or, if you want to keep it more generic, "ebook".

@mojavelinux mojavelinux deleted the kf8 branch October 31, 2015 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants