Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Circular with Oval and add Miri tests #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Posnet
Copy link

@Posnet Posnet commented May 6, 2024

Oval is a nicer, maintained fork of Circular, that removes the unsafe and unsound code (it replaces them with stdlib features that didn't exist at the time of Circular's writing such as copy_within, so it should generate the same code).
Replacing Ciruclar with Oval means we can now add Miri tests to check for undefined/unsound behavior in unsafe rust (even though there isn't in this crate).

Oval is a drop in replacement for ciruclar useful fixes merged.
Specificall it removes all occurences of unsound and unsafe behavior,
and so will allow for Miri testing.
@Posnet
Copy link
Author

Posnet commented May 6, 2024

Also, apologies with the noise of the other pull request I opened and closed, I realized I had the wrong git config for those commits, I had my gmail set instead of my git one.

@chifflier chifflier self-assigned this May 7, 2024
Miri is the unsound/undefined behavior checker for unsafe Rust.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants