Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi: remove dependency on wasi v0.11 #502

Merged
merged 2 commits into from
Oct 4, 2024
Merged

wasi: remove dependency on wasi v0.11 #502

merged 2 commits into from
Oct 4, 2024

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Sep 27, 2024

Having two wasi versions in dependencies causes some annoyances in downstream users, e.g. v0.11 gets show as an "outdated" dependency. The dependency is removed by directly linking random_get by following the wasi code.

@newpavlov
Copy link
Member Author

@yoshuawuyts
Could you take a look?

@newpavlov newpavlov changed the title wasi: remove dependency on wasi v0.11 wasi: remove dependency on the wasi crate Sep 27, 2024
@newpavlov newpavlov changed the title wasi: remove dependency on the wasi crate wasi: remove dependency on wasi v0.11 Sep 27, 2024
@newpavlov
Copy link
Member Author

newpavlov commented Sep 27, 2024

Huh, it seems we can not "just" link to get_random_u64. It looks like it needs a pretty arcane linking magic...

@newpavlov newpavlov merged commit 26b88ca into master Oct 4, 2024
104 checks passed
@newpavlov newpavlov deleted the wasip1 branch October 4, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant