Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndk: Add AMidi interface #353

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

ndk: Add AMidi interface #353

wants to merge 56 commits into from

Commits on Oct 4, 2022

  1. ndk: Add AMidi interface

    @paxbun
    paxbun committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    2daf09c View commit details
    Browse the repository at this point in the history

  2. ndk: Remove needless explicit lifetimes in midi.rs

    @paxbun
    paxbun committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9456589 View commit details
    Browse the repository at this point in the history

  3. ndk: Fix mismatching doc comments in midi.rs

    @paxbun
    paxbun committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9cf8581 View commit details
    Browse the repository at this point in the history

  4. ndk: Remove get_ prefix from midi.rs

    @paxbun
    paxbun committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9f7c9ef View commit details
    Browse the repository at this point in the history

  5. ndk: Fix doc comments of MidiOutputPort::receive

    @paxbun
    paxbun committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    466bf4a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. ndk-sys: Add feature midi 

    Added Cargo feature `midi` and optional linkage to `libamidi.so`
    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    4013f68 View commit details
    Browse the repository at this point in the history

  2. ndk: Add feature midi 

    Added Cargo feature `midi`, which enables `ffi/midi`, `api-level-29`,
and NdkMediaError in `media`
    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    ff6697c View commit details
    Browse the repository at this point in the history

  3. ndk: Make Midi types implement Send

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    02630b0 View commit details
    Browse the repository at this point in the history

  4. ndk: Update ndk/src/midi.rs 

    Fixed typos in comments about thread-safety in midi.rs

Co-authored-by: Marijn Suijten <[email protected]>
    @paxbun @MarijnS95
    paxbun and MarijnS95 authored Oct 5, 2022
    Configuration menu
    Copy the full SHA
    d3d616e View commit details
    Browse the repository at this point in the history

  5. ndk: Fix mismatching doc comments in midi.rs

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    4f53506 View commit details
    Browse the repository at this point in the history

  6. ndk: Fix link to ndk-samples with a permalink

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    15b917f View commit details
    Browse the repository at this point in the history

  7. ndk: Replace try_from_primitives in midi.rs with try_from

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    5ae1cad View commit details
    Browse the repository at this point in the history

  8. ndk: Make MidiOutputPort::receive return timestamp only with MidiOpco… 

    …de::Data
    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    06ebda5 View commit details
    Browse the repository at this point in the history

  9. ndk: Add ptr exposing functions to wrappers in midi.rs

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    2c92479 View commit details
    Browse the repository at this point in the history

  10. ndk: Raise error when 2 or more msgs received in MidiOutputPort

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    b2ec4ea View commit details
    Browse the repository at this point in the history

  11. ndk: Remove as_ptr() from structs in midi.rs

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    6f262cc View commit details
    Browse the repository at this point in the history

  12. ndk: Add more strict opcode checks to MidiOutputPort

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    01877bc View commit details
    Browse the repository at this point in the history

  13. ndk: Make msg for unexpected opcode in midi.rs more clear

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    48b4416 View commit details
    Browse the repository at this point in the history

  14. ndk: Fix vague doc comments in midi.rs

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    aa26247 View commit details
    Browse the repository at this point in the history

  15. ndk: Add mod media_error 

    Moved media::{construct, MediaErrorResult, NdkMediaError} to separate
module as midi.rs is also dependent on them
    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    8235a5c View commit details
    Browse the repository at this point in the history

  16. ndk: Remove pub use for MediaErrorResult from media/mod.rs

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    12df844 View commit details
    Browse the repository at this point in the history

  17. ndk: Remove pub use from media/mod.rs

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    34357c7 View commit details
    Browse the repository at this point in the history

  18. ndk: Reflect midi.rs changes to CHANGELOG.md

    @paxbun
    paxbun committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    23b18b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. fix: Make MidiDevice::from_java unsafe

    @paxbun
    paxbun committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    c79c8c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merge branch 'master' into feat/amidi

    @paxbun
    paxbun committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    895350b View commit details
    Browse the repository at this point in the history

  2. fix(ndk): Remove all occurrences of ffi::size_t from midi.rs

    @paxbun
    paxbun committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    acce571 View commit details
    Browse the repository at this point in the history

  3. fix(ndk): Remove unnecessary casts from midi.rs

    @paxbun
    paxbun committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    8900c1c View commit details
    Browse the repository at this point in the history

  4. ndk: Rework media error types 

    - Clean up the names: we're already in the `ndk` crate so no need to
  repeat that in the type name;
- Make the types available outside the `media` module, so that they can
  be used in `AMidi` bindings which are not located inside
  `libmediandk.so` (but `libamidi.so`);
- Add documentation comments.
    @MarijnS95
    MarijnS95 committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    95220e7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ndk-rework-media-error' into feat/amidi

    @paxbun
    paxbun committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    85288eb View commit details
    Browse the repository at this point in the history

  6. fix(ndk): Reflect changes in media_error to midi

    @paxbun
    paxbun committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    cc1c2e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Merge branch 'master' into feat/amidi

    @paxbun
    paxbun authored Jun 23, 2023
    Configuration menu
    Copy the full SHA
    200ab56 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Update comments in ndk/src/midi.rs 

    Co-authored-by: Marijn Suijten <[email protected]>
    @paxbun @MarijnS95
    paxbun and MarijnS95 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    408e460 View commit details
    Browse the repository at this point in the history

  2. Update ndk/src/midi.rs 

    Co-authored-by: Marijn Suijten <[email protected]>
    @paxbun @MarijnS95
    paxbun and MarijnS95 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9a5744b View commit details
    Browse the repository at this point in the history

  3. Update ndk/src/midi.rs 

    Co-authored-by: Marijn Suijten <[email protected]>
    @paxbun @MarijnS95
    paxbun and MarijnS95 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    412b6ad View commit details
    Browse the repository at this point in the history

  4. Update ndk/CHANGELOG.md 

    Co-authored-by: Marijn Suijten <[email protected]>
    @paxbun @MarijnS95
    paxbun and MarijnS95 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    aa4467e View commit details
    Browse the repository at this point in the history

  5. fix: Remove impl Send for MidiDevice 

    Co-authored-by: Marijn Suijten <[email protected]>
    @paxbun @MarijnS95
    paxbun and MarijnS95 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3cfaad4 View commit details
    Browse the repository at this point in the history

  6. Fix comments in ndk/src/media_error.rs

    @paxbun
    paxbun committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    2e036d2 View commit details
    Browse the repository at this point in the history

  7. ndk: Make "midi" feature dependent on "media"

    @paxbun
    paxbun committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    aa79a19 View commit details
    Browse the repository at this point in the history

  8. fix: Remove redundant Result mapping from midi.rs

    @paxbun
    paxbun committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0341b4d View commit details
    Browse the repository at this point in the history

  9. ndk: Add MidiDeviceType::Unknown

    @paxbun
    paxbun committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c8b2b2e View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. ndk: Add doc-comments to MidiInputPort

    @paxbun
    paxbun committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    6044fc2 View commit details
    Browse the repository at this point in the history

  2. ndk: Add doc-comments to fields of MidiOpcode::Data

    @paxbun
    paxbun committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    f22054d View commit details
    Browse the repository at this point in the history

  3. ndk: Reference the Java Android MIDI docs in the doc-comments

    @paxbun
    paxbun committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    734b81b View commit details
    Browse the repository at this point in the history

  4. ndk: Fix doc-comments of MidiOutputPort::receive

    @paxbun
    paxbun committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    7220a9a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. ndk: Drop Send for ndk::midi::Midi*Port

    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    241b096 View commit details
    Browse the repository at this point in the history

  2. ndk: Describe about Java VM thread attachment in the safety section o… 

    …f doc-comments of MidiDevice
    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d9ef310 View commit details
    Browse the repository at this point in the history

  3. ndk: Add safe wrapper of midi

    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    31159dc View commit details
    Browse the repository at this point in the history

  4. ndk: Fix typos in ndk::midi::safe

    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    129edc2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat/amidi

    @paxbun
    paxbun authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    1ea5b32 View commit details
    Browse the repository at this point in the history

  6. ndk: Fix clippy warnings in ndk::midi

    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    83fe4b2 View commit details
    Browse the repository at this point in the history

  7. ndk: Make examples in ndk::midi compilable

    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8c64160 View commit details
    Browse the repository at this point in the history

  8. ndk: Remove link to SafeMidiDeviceBox from the module-level doc-comme… 

    …nt of ndk::midi::safe
    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    5428ca7 View commit details
    Browse the repository at this point in the history

  9. ndk: Add more detailed description about safety of AMidi functions to… 

    … ndk::midi::safe
    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    802ab4a View commit details
    Browse the repository at this point in the history

  10. ndk: Add missing brackets to links to functions in doc-comments in nd… 

    …k::midi
    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    300118e View commit details
    Browse the repository at this point in the history

  11. ndk: Enable media_error when "midi" is enabled

    @paxbun
    paxbun committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8086a7d View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Merge remote-tracking branch 'origin/master' into feat/amidi

    @paxbun
    paxbun committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    5707555 View commit details
    Browse the repository at this point in the history