Refactor change detection for rustdoc and download-rustc #131043
+50
−39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the change detection logic in the build process by consolidating redundant code into a new helper method. The key changes include the removal of duplicate logic for checking changes in directories and the addition of a new method to handle this functionality.
Refactoring and code simplification:
src/bootstrap/src/core/build_steps/tool.rs
: Removed redundant change detection logic and replaced it with a call to the newcheck_for_changes
method.src/bootstrap/src/core/config/config.rs
: Added a new methodcheck_for_changes
to centralize the logic for detecting changes in specified directories since a given commit.src/bootstrap/src/core/config/config.rs
: Updated the existing change detection code to use the newcheck_for_changes
method.Cleanup:
src/bootstrap/src/core/build_steps/tool.rs
: Removed the unused importgit
from the helpers module.r? @albertlarsan68