Windows Support #379
Draft
Windows Support #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add directory where asan DLL is to path when running. Improve diagnostics
Co-authored-by: Blake Johnson <[email protected]>
|
Nice! Does |
fitzgen
reviewed
Jul 25, 2024
|
I added a function for setting up a Windows JobObject so that all child processes are cleaned up when cargo-fuzz is terminated. |
Hmm trying it with Where the test project is just an empty Rust template with an empty fuzzer. |
|
I did a dumpbin, and it looks like it requires some of the symbols the asan DLL provides. So on Windows it unconditionally needs to be linked with |
This is because any cargo-run needs to be able to run the binary :)
|
Wow this library desperately needs golden file testing. The weird |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I will clean up the commits once it's mostly working
This crate is quite close to supporting Windows. The crates will already build without issue. Things to do:
clang_rt.asan_dynamic-x86_64.dllis in to $PATH of the fuzzer processWith this change it is possible to run the fuzzers too.
This directory is not on PATH by default, so the binary cannot load the DLL when run. It is recommended to add it to PATH before running the binary. It somewhere like
C:\Program Files (x86)\Microsoft Visual Studio\[MSVC VERSION]\BuildTools\VC\Tools\MSVC\[RT VERSION]\bin\Hostx64\x64asan is fairly new to MSVC so it will only exist on versions newer than 2019.
This DLL resides in the same directory as
link.exe&cl.exeso the most accurate way to obtain it is to do the same process rustc does to get the location oflink.exe. This ensures that the runtime & msvc version matches the one used to compile the binary.Note: this is required for
sanitizers = noneas well. Windows does not support any other sanitizers at this time.There are errors that are *nix specific that need to be fixed up. It is mainly fixing str paths that will be displayed incorrectly on Windows.
init_twice
add_twice
build_dev
build_all
build_one
run_a_few_inputs
run_alt_corpus
run_diagnostic_contains_fuzz_dir
run_one_input
run_without_sanitizer_with_crash
run_with_crash
run_with_coverage
tmin
Ensure child processes are always terminated
The win32 Job Objects API is what is needed for this. Essentially, get its info, set the info so that it has JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE set.
For some reason on my work computer the fuzzer just hangs when it opens, not doing anything. At home it seems to work as expected. I'm not sure why.
Looks like every thread it hanging out in `NtWaitForAlertByThreadId`. IDK what that means.