Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spi: move async ExclusiveDevice to embedded-hal-bus. #474

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Jul 15, 2023

!! REQUIRES #472 (for the MSRV bump and CI fixes) !!

Same logic as to why the blocking bus impls are in a separate crate: if we ever want to stabilize embedded-hal-async 1.0 we can't make breaking changes to ExclusiveDevice, so it's best to keep it in a separate crate so we can.

@Dirbaio Dirbaio requested a review from a team as a code owner July 15, 2023 14:02
@Dirbaio Dirbaio force-pushed the bus-stuff branch 2 times, most recently from 384abe8 to 5795d2b Compare July 15, 2023 14:04
@eldruin eldruin mentioned this pull request Jul 17, 2023
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thank you!

@eldruin eldruin added this pull request to the merge queue Jul 17, 2023
Merged via the queue into rust-embedded:master with commit 3d069fa Jul 17, 2023
12 checks passed
@bugadani
Copy link
Contributor

To be quite honest, ExclusiveDevice is both the sync and the async implementor, so including that under the asynch module is a bit weird. It was equally weird to have it in embedded-hal-async but that's the past. I feel like the type could be moved up from asynch::spi to spi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants