v17: Finish network section #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the key docs now that we worked out that a bunch of RPC methods are either deprecated or do not return anything. We choose not to implement deprecated for v17 because v17.1 is so far back anyways. And obviously if nothing is returned we don't need a type for it.
tcharding
force-pushed
the
10-16-network
branch
from
1c8433c
to
7e668f8
Compare
Finish implementing all JSON types for stuff under the network section. Includes various cleanups and testing.
tcharding
force-pushed
the
10-16-network
branch
from
7e668f8
to
c3b9b6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish all RPC methods under the
networksection of the docs. Do a bunch of clean ups on the way.