Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tracking PR: v0.12.0 #189

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jul 31, 2024

In preparation for release add a changelog entry and bump the version.

(Includes a patch up front to upgrade the version of upload-artifact and download-artifact actions to fix the fuzz CI job.)

@tcharding tcharding marked this pull request as draft July 31, 2024 09:43
@tcharding tcharding changed the title Bump version to 0.12.0 Release tracking PR: v0.12.0 Sep 18, 2024
@tcharding tcharding marked this pull request as ready for review September 18, 2024 04:07
In the `fuzz` job we are using `upload-artifact@v2` and CI auto-fails
because this version has been deprecated. Upgrade to version 3.
In preparation for release add a changelog entry and bump the version.
@tcharding
Copy link
Member Author

Do you want #200 to go into this @apoelstra?

@apoelstra
Copy link
Member

@tcharding yeah -- I'm actually pretty close to having error correction working but it'll require a few more breaking changes.

In particular I need to add a few more fields to the Checksum trait which will break all users that implement that. This is an annoying but ultimately mechanical fix (you need to use the PrintImpl object and print it then copy/paste the result into your code). This might actually be the only breaking change other than #200, but I'm not sure.

I'm tempted to hold off on this release until correction is done, but if the LDK people really want these latest PRs then I'd like to get #200 in and also I'll PR the new Checksum changes, without the rest of error correction, and I'll try to do the rest without further breakage.

@tcharding
Copy link
Member Author

Converting to draft to give you a minute to work on the error corrections stuff.

@tcharding tcharding marked this pull request as draft September 18, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants