Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer Ownership of Normal-Ancient-Teleports #6520

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zoltander
Copy link

image

The purpose of this plugin is to sensibly rename the teleports of the ancient spellbook to their map/p.o.i. locations, similarly to Nexus Menu Map.

@runelite-github-app
Copy link

runelite-github-app bot commented Aug 28, 2024

@YvesW
Copy link
Member

YvesW commented Aug 28, 2024

Does this plugin differ significantly from https://runelite.net/plugin-hub/show/normal-ancient-teleports?

@zoltander
Copy link
Author

zoltander commented Aug 28, 2024

Does this plugin differ significantly from https://runelite.net/plugin-hub/show/normal-ancient-teleports?

That plugin is broken for spellbook unfortunately, same idea though.

@YvesW
Copy link
Member

YvesW commented Aug 28, 2024

Could you contribute your fix to their repo? We strongly prefer it if people contribute to existing plugins, since that results in the already existing userbase also benefitting from your fixes, your code having an immediate bigger install base, and it prevents pluginhub clutter and/or fragmentation. https://github.com/runelite/plugin-hub?tab=readme-ov-file#contribute-to-existing-plugins

@zoltander
Copy link
Author

I did try opening an issue about it but I don't think it is being maintained.

IdylRS/runelite-plugins#6

@YvesW
Copy link
Member

YvesW commented Aug 28, 2024

You should open a PR with the fix, and potentially ask if you can be added as a contributor in case Idyl does not want to maintain the plugin anymore.
If that fails, there are steps to transfer the plugin if needed, but we greatly prefer it if a PR gets merged or people get added as contributor.

@zoltander
Copy link
Author

You should open a PR with the fix, and potentially ask if you can be added as a contributor in case Idyl does not want to maintain the plugin anymore. If that fails, there are steps to transfer the plugin if needed, but we greatly prefer it if a PR gets merged or people get added as contributor.

Thanks for the advice. I made a PR here: IdylRS/runelite-plugins#7
Let's see how it goes.

@zoltander
Copy link
Author

zoltander commented Sep 18, 2024

Given that I opened an initial issue on Aug 6th and I submitted a PR with the fix 3 weeks ago and IdylRS has no activity on GitHub since July 2023, I think it is safe to say the original plugin is abandoned.

I have updated this pull request to instead point the plugin toward my fork assuming that is the correct way to transfer ownership of it. Please take a look and let me know if anything else needs to be done.

Here's the diff for reference: IdylRS/runelite-plugins@normal-ancient-teleports...zoltander:Normal-Ancient-Teleports:master

@zoltander zoltander changed the title Create ancient-teleports-renamed Transfer Ownership of Normal-Ancient-Teleports Sep 18, 2024
@YvesW
Copy link
Member

YvesW commented Sep 20, 2024

I recommend re-opening your PR, so Idyl still has time to look at it.
@IdylRS would you be fine with adding this person as contributor to your repo, or looking at their proposed changes?

If you want to transfer ownership, we require receipts of contacting Idyl in any way possible with the specific request to be added as contributor, and that if he fails to respond, his repo will be transferred. Since Idyl is a content creator, you'll be able to contact him via quite a couple of ways.

  • Via issues/PR: I recommend re-opening the PR and adding that you'd like to be added as contributor, and that if he fails to respond, the repo will be transfer.
  • Discord. He might have a discord server or handle on his yt or video description. @ him in the RL Discord if he's in there.
  • Email. You can very likely get this from his commits. Alternatively, he also has an email on his yt (maybe a different one).
  • Other socials he has on his github, youtube channel, or yt vids.

@hash-cloud-dev
Copy link

Can we please get this fixed anyone?

@cdfisher
Copy link
Contributor

cdfisher commented Oct 4, 2024

Can we please get this fixed anyone?

Generally a transfer of ownership won't happen in under a month unless there's a response from the plugin's current owner. Since Yves only reached out two weeks ago, it will probably be a few weeks.

@YvesW
Copy link
Member

YvesW commented Oct 4, 2024

Additionally, I also don't see any receipts of email messages, twitter posts, youtube comments etc. (see my previous message). Idyl probably also has his own Discord. He's a content creator, so there should be many ways to reach him to ask to be added as contributor.

@evilgenious448
Copy link

Could it possibly be PR'd into Llemonduck's Easy Teleports plugin? That plugin currently doesn't include spellbooks, but based on the description of the plugin it would be suitable:

Replaces difficult-to-remember teleport options in-game with custom values, defaulting to more sensible values.

Perhaps that would be quicker and less troublesome solution than getting a response from Idyl?

@zoltander
Copy link
Author

Additionally, I also don't see any receipts of email messages, twitter posts, youtube comments etc. (see my previous message). Idyl probably also has his own Discord. He's a content creator, so there should be many ways to reach him to ask to be added as contributor.

IMG_3346
IMG_3347

It appears he is not in the RuneLite discord server, so I dm’d him on twitter. I might need to comment on one of his posts on twitter or youtube because I have not heard back. I believe his discord server is patreon only.

@YvesW
Copy link
Member

YvesW commented Oct 7, 2024

@IdylRS Could you add Zoltander to your nornal-ancient-teleports repo as collaborator, or at least reply? If you fail to reply to this message within 2 weeks, your plugin will be transferred to him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants