-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer Ownership of Normal-Ancient-Teleports #6520
base: master
Are you sure you want to change the base?
Conversation
|
Does this plugin differ significantly from https://runelite.net/plugin-hub/show/normal-ancient-teleports? |
That plugin is broken for spellbook unfortunately, same idea though. |
Could you contribute your fix to their repo? We strongly prefer it if people contribute to existing plugins, since that results in the already existing userbase also benefitting from your fixes, your code having an immediate bigger install base, and it prevents pluginhub clutter and/or fragmentation. https://github.com/runelite/plugin-hub?tab=readme-ov-file#contribute-to-existing-plugins |
I did try opening an issue about it but I don't think it is being maintained. |
You should open a PR with the fix, and potentially ask if you can be added as a contributor in case Idyl does not want to maintain the plugin anymore. |
Thanks for the advice. I made a PR here: IdylRS/runelite-plugins#7 |
Given that I opened an initial issue on Aug 6th and I submitted a PR with the fix 3 weeks ago and IdylRS has no activity on GitHub since July 2023, I think it is safe to say the original plugin is abandoned. I have updated this pull request to instead point the plugin toward my fork assuming that is the correct way to transfer ownership of it. Please take a look and let me know if anything else needs to be done. Here's the diff for reference: IdylRS/runelite-plugins@normal-ancient-teleports...zoltander:Normal-Ancient-Teleports:master |
I recommend re-opening your PR, so Idyl still has time to look at it. If you want to transfer ownership, we require receipts of contacting Idyl in any way possible with the specific request to be added as contributor, and that if he fails to respond, his repo will be transferred. Since Idyl is a content creator, you'll be able to contact him via quite a couple of ways.
|
Can we please get this fixed anyone? |
Generally a transfer of ownership won't happen in under a month unless there's a response from the plugin's current owner. Since Yves only reached out two weeks ago, it will probably be a few weeks. |
Additionally, I also don't see any receipts of email messages, twitter posts, youtube comments etc. (see my previous message). Idyl probably also has his own Discord. He's a content creator, so there should be many ways to reach him to ask to be added as contributor. |
Could it possibly be PR'd into Llemonduck's Easy Teleports plugin? That plugin currently doesn't include spellbooks, but based on the description of the plugin it would be suitable:
Perhaps that would be quicker and less troublesome solution than getting a response from Idyl? |
It appears he is not in the RuneLite discord server, so I dm’d him on twitter. I might need to comment on one of his posts on twitter or youtube because I have not heard back. I believe his discord server is patreon only. |
@IdylRS Could you add Zoltander to your nornal-ancient-teleports repo as collaborator, or at least reply? If you fail to reply to this message within 2 weeks, your plugin will be transferred to him. |
The purpose of this plugin is to sensibly rename the teleports of the ancient spellbook to their map/p.o.i. locations, similarly to Nexus Menu Map.