Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create gim-buddy #6332

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Create gim-buddy #6332

wants to merge 11 commits into from

Conversation

fNudz
Copy link

@fNudz fNudz commented Jul 19, 2024

Created gim-buddy

@fNudz
Create gim-buddy
ce43338 
Created gim-buddy
@runelite-github-app
Copy link

runelite-github-app bot commented Jul 19, 2024 •
edited
Loading

New plugin gim-buddy: https://github.com/fNudz/gim-buddy/tree/70ff84b48b3b337bbe9d48cbfda0ec7b35047221

@YvesW
Copy link
Member

YvesW commented Jul 19, 2024

@GarrettJhnsn #6330 (comment)

fNudz and others added 4 commits July 18, 2024 22:19
@fNudz
Update gim-buddy
d3f1f5d 
GIM Buddy is a RuneLite plugin designed to enhance the Group Ironman Mode (GIM) experience. Streamlining collaboration and communication, GIM Buddy's goal is to provide a suite of tools within a convenient side panel interface.
@fNudz
Update gim-buddy
ec72710 
GIM Buddy is a RuneLite plugin designed to enhance the Group Ironman Mode (GIM) experience. Streamlining collaboration and communication, GIM Buddy's goal is to provide a suite of tools within a convenient side panel interface.
@fNudz
Update gim-buddy
49a9f10 
GIM Buddy is a RuneLite plugin designed to enhance the Group Ironman Mode (GIM) experience. Streamlining collaboration and communication, GIM Buddy's goal is to provide a suite of tools within a convenient side panel interface.
@fNudz
Update gim-buddy
18ed26d 
All-in-one RuneLite plugin tailored to the specific needs of a group ironman team, providing a suite of tools to enhance the overall experience.
@fNudz
Update gim-buddy
8eaa7ec 
All-in-one RuneLite plugin tailored to the specific needs of a group ironman team, providing a suite of tools to enhance the overall experience.
@fNudz
Update gim-buddy
53f3244 
All-in-one RuneLite plugin tailored to the specific needs of a group ironman team, providing a suite of tools to enhance the overall experience.
@fNudz
Update gim-buddy
6197629 
All-in-one RuneLite plugin tailored to the specific needs of a group ironman team, providing a suite of tools to enhance the overall experience.
@iProdigy
Copy link
Member

ImageIO.read(new File("src/main/resources/icon.png")) would not work in production as explained here: https://github.com/runelite/plugin-hub?tab=readme-ov-file#plugin-resources

(you should switch to ImageUtil.loadImageResource)

@fNudz
Update gim-buddy
805755d 
updated icon loader with imageUtil.loadImageResource() per runelite guideline.
@fNudz
Update gim-buddy
f7a390b 
updated server select issue
@LlemonDuck
Copy link
Contributor

You should gitignore the bin/ folder which appears to contain the compiled project (which isn't the default gradle build location, so I'm not sure how you ended up with it there anyway)

Make sure you also remove it after adding it to the gitignore

git rm -rf --cached bin

@fNudz
Update gim-buddy
d5147f0 
updated gitignore to handle unnecessary bin folder
@Unmoon
Copy link
Contributor

Unmoon commented Sep 19, 2024

I think you need to add a warning like this since it's possible to configure the plugin to send data outside your computer.

@MESLewis
Copy link
Member

MESLewis commented Oct 3, 2024

Marking as draft for now. Please make the requested changes, then mark the plugin as ready for review.

@MESLewis MESLewis marked this pull request as draft October 3, 2024 15:43
@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
plugin added waiting for author waiting for the pr author to make changes or respond to questions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fNudz @YvesW @iProdigy @LlemonDuck @Unmoon @MESLewis