Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a broken JSON in log output #464

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Commits on Jun 18, 2024

  1. Fixed a broken JSON in log output

    Since v0.15, a JSON format in the log output has been broken. When the original log is in the following format:
    
    ```
    "{\"id\":27,\"result\":{\"data\":\"(snipped)\"},\"sessionId\":\"E2C753A9154794C390311B8647590A03\"}"
    ```
    
    It gets converted to a format without a closing } like this:
    
    ```
    "    ◀ 10.680710212999657 {\"id\":27,\"result\":\"Set FERRUM_LOGGING_SCREENSHOTS=true to see screenshots in Base64\"\n"
    ```
    
    Upon investigation, I found that the string replacement performed when SKIP_LOGGING_SCREENSHOTS is enabled was unintentionally breaking the JSON format. Therefore, I modified the regular expression used for the replacement.
    willnet committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c000968 View commit details
    Browse the repository at this point in the history