Stop process if error during initialise #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Ferrum with Puma and found that if an error is raised during initialisation of the browser, then chrome processes do not get stopped until the garbage collection runs.
Equally there is no way to stop these processes from the perspective of somebody using Ferrum because we never get a browser object back as the initialize method is raising the error.
From what i can tell, garbage collection doesn't run immediately and so these processes can live for longer then they need to.
By catching any errors raised between the process being started and returning from the browser initialiser then we can ensure that we stop any processes which were started.