Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Supports capture area screenshot #410

Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat: Supports capture area screenshot #410

merged 1 commit into from
Nov 9, 2023

Conversation

erickgskovik
Copy link
Contributor

Fixes #389

I made selector and area optional arguments. In the implementation, I think that the pull requests shows the true intention of the screenshot region.

If full: true, It tries to capture full screenshot with full size browser window and then viewport if the full size is not accurate.
If full: false, :selector is preferred if defined. Then :area. Otherwise, the default will be the viewport.

Applying default scale (1.0) will not affect the result anyway.

@sandstrom
Copy link

@route friendly ping 😄

@route
Copy link
Member

route commented Nov 9, 2023

I'm back and going one by one from top to bottom ;)

@route route merged commit 2f9e94f into rubycdp:main Nov 9, 2023
10 checks passed
@route
Copy link
Member

route commented Nov 9, 2023

Thanks, nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send Emulation commands to Page
3 participants