fix: Close connections

CHANGELOG.md

@@ -13,7 +13,7 @@
 - Resizing page on creation is gone and moved to Cuprite [#427]
 - Min Ruby version is 2.7
 - Refactored internal API of `Ferrum::Browser`, `Ferrum::Page`, `Ferrum::Context`, `Ferrum::Contexts`, `Ferrum::Target`
-instead of passing browser and making cyclic dependency on the browser instance, we pass now a simple client [#431]
+instead of passing browser and making cyclic dependency on the browser instance, we pass now a thin client [#431]
 - Bump `websocket-driver` to `~> 0.7` [#432]
 - Got rid of `Concurrent::Async` in `Ferrum::Browser::Subscriber` [#432]
 

lib/ferrum/browser.rb

@@ -208,6 +208,7 @@ def restart
     def quit
       return unless @client
 
+      contexts.close_connections
       @client.close
       @process.stop
       @client = @process = @contexts = nil

lib/ferrum/browser/web_socket.rb

@@ -52,6 +52,7 @@ def on_message(event)
 
       def on_close(_event)
         @messages.close
+        @sock.close
         @thread.kill
       end
 
@@ -65,7 +66,7 @@ def send_message(data)
 
       def write(data)
         @sock.write(data)
-      rescue EOFError, Errno::ECONNRESET, Errno::EPIPE
+      rescue EOFError, Errno::ECONNRESET, Errno::EPIPE, IOError # rubocop:disable Lint/ShadowedException
         @messages.close
       end
 
@@ -83,7 +84,7 @@ def start
 
             @driver.parse(data)
           end
-        rescue EOFError, Errno::ECONNRESET, Errno::EPIPE
+        rescue EOFError, Errno::ECONNRESET, Errno::EPIPE, IOError # rubocop:disable Lint/ShadowedException
           @messages.close
         end
       end

lib/ferrum/context.rb

@@ -71,6 +71,14 @@ def delete_target(target_id)
       @targets.delete(target_id)
     end
 
+    def close_targets_connection
+      @targets.each_value do |target|
+        next unless target.attached?
+
+        target.page.close_connection
+      end
+    end
+
     def dispose
       @contexts.dispose(@id)
     end

lib/ferrum/contexts.rb

@@ -45,11 +45,16 @@ def create(**options)
 
     def dispose(context_id)
       context = @contexts[context_id]
+      context.close_targets_connection
       @client.command("Target.disposeBrowserContext", browserContextId: context.id)
       @contexts.delete(context_id)
       true
     end
 
+    def close_connections
+      @contexts.each_value(&:close_targets_connection)
+    end
+
     def reset
       @default_context = nil
       @contexts.each_key { |id| dispose(id) }

lib/ferrum/page.rb

@@ -120,7 +120,13 @@ def go_to(url = nil)
     def close
       @headers.clear
       client(browser: true).command("Target.closeTarget", targetId: @target_id)
-      @page_client.close
+      close_connection
+
+      true
+    end
+
+    def close_connection
+      @page_client&.close
     end
 
     #

spec/spec_helper.rb

@@ -46,7 +46,7 @@
   end
 
   config.after(:all) do
-    @browser&.quit
+    @browser.quit
   end
 
   config.before(:each) do