Install rustc #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not going to `apt-get install rustc`, because what is installed using apt-get tends to be too old, compared to what we need (1.60.0+).
|
This pull request is needed for ruby/ruby#5870 |
XrXr
reviewed
May 2, 2022
Dockerfile
Outdated
|
|
||
| RUN set -ex \ | ||
| && apt-get update \ | ||
| && apt-get install ${packages} \ | ||
| libjemalloc-dev openssl ruby tzdata valgrind sudo \ | ||
| libcapstone-dev \ |
There was a problem hiding this comment.
Suggested change
| libcapstone-dev \ |
It should work without this since the Rust crate we use takes care of building libcapstone from source.
There was a problem hiding this comment.
This is for CI. If precompiled library in our docker image reduces build time, I think it's worth.
|
No plans to merge this for now. Will revisit later if needed again. |
|
Bump! We now in fact need this. Let us revive. |
XrXr
approved these changes
Jul 5, 2023
Actually this repo's CI is not working as expected. It already pushed images based on this pull request. So yeah, we found a problem already, and was fixed. Thanks for approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not going to
apt-get install rustc, because what is installed using apt-get tends to be too old, compared to what we need (1.60.0+).