Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop specifying the gem version of strscan in benchmarks. #113

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

naitoh
Copy link
Contributor

@naitoh naitoh commented Feb 15, 2024

[Why]

Because benchmarks are broken when new strscan is released.

https://github.com/ruby/rexml/actions/runs/7825513689/job/21349811563

RUBYLIB= BUNDLER_ORIG_RUBYLIB= /opt/hostedtoolcache/Ruby/3.3.0/x64/bin/ruby -v -S benchmark-driver /home/runner/work/rexml/rexml/benchmark/parse.yaml

ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux]
Calculating -------------------------------------
                     rexml 3.2.6      master  3.2.6(YJIT)  master(YJIT)
/opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/dependency.rb:315:in `to_specs': Could not find 'strscan' (= 3.0.9) - did find: [strscan-3.1.0,strscan-3.0.7] (Gem::MissingSpecVersionError)
Checked in 'GEM_PATH=/home/runner/.local/share/gem/ruby/3.3.0:/opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/gems/3.3.0' , execute `gem env` for more information
	from /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/dependency.rb:325:in `to_spec'
	from /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/core_ext/kernel_gem.rb:56:in `gem'
	from /tmp/benchmark_driver-20240208-1790-njwk6u.rb:1:in `<main>'

[Why]
Because benchmarks are broken when new strscan is released.

https://github.com/ruby/rexml/actions/runs/7825513689/job/21349811563

RUBYLIB= BUNDLER_ORIG_RUBYLIB= /opt/hostedtoolcache/Ruby/3.3.0/x64/bin/ruby -v -S benchmark-driver /home/runner/work/rexml/rexml/benchmark/parse.yaml
```
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux]
Calculating -------------------------------------
                     rexml 3.2.6      master  3.2.6(YJIT)  master(YJIT)
/opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/dependency.rb:315:in `to_specs': Could not find 'strscan' (= 3.0.9) - did find: [strscan-3.1.0,strscan-3.0.7] (Gem::MissingSpecVersionError)
Checked in 'GEM_PATH=/home/runner/.local/share/gem/ruby/3.3.0:/opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/gems/3.3.0' , execute `gem env` for more information
	from /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/dependency.rb:325:in `to_spec'
	from /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/core_ext/kernel_gem.rb:56:in `gem'
	from /tmp/benchmark_driver-20240208-1790-njwk6u.rb:1:in `<main>'

```
@kou kou merged commit 372daf1 into ruby:master Feb 15, 2024
39 checks passed
@naitoh naitoh deleted the fix_benchmark_strscan branch February 15, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants