Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpath: Fix normalize_space(array) case #111

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

flatland001
Copy link
Contributor

@flatland001 flatland001 commented Feb 7, 2024

GitHub: fix GH-110

Fixed a bug in REXML::Functions.normalize_space(array) and introduced test cases for it:

  • Corrected a typo in the variable name within the collect block (string -> x).
  • Added test_normalize_space_strings to test/functions/test_base.rb.

Replaced the variable 'string' with 'x' inside the collect block.
…y#110

to validate `REXML::Functions::normalize_space()` functionality
test/functions/test_base.rb Outdated Show resolved Hide resolved
test/functions/test_base.rb Outdated Show resolved Hide resolved
Renamed test_normalize_space2 for better clarity and updated tests to use Array of String for expected data. ruby#110

Co-authored-by: Sutou Kouhei <[email protected]>
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Could you update the PR description before we merge this? We'll use the PR title and description for commit message.

@flatland001
Copy link
Contributor Author

My apologies for the oversight! Thank you for pointing that out. I've made a slight adjustment to the PR description. Does this look alright to you?

@kou kou changed the title Fix functions normalize space #110 Fix normalize_space(array) case Feb 8, 2024
@kou kou changed the title Fix normalize_space(array) case xpath: Fix normalize_space(array) case Feb 8, 2024
@kou kou merged commit 444c9ce into ruby:master Feb 8, 2024
39 checks passed
@kou
Copy link
Member

kou commented Feb 8, 2024

Thanks. I've updated a bit and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Potential Typo in REXML::Functions::normalize_space() Implementation
2 participants