Improve help/show_cmds message during debugger integration #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
changed the title
st0012
force-pushed
the
improve-help-message-during-debugger-integration
branch
from
f07eb5f
to
e5e8c6d
Compare
tompng
reviewed
Aug 29, 2023
st0012
force-pushed
the
improve-help-message-during-debugger-integration
branch
from
e5e8c6d
to
af72af0
Compare
tompng
approved these changes
Aug 29, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 29, 2023
integration (ruby/irb#693) * `help` should display debugger's help during irb:rdbg session * Update `show_cmds`'s output when in irb:rdbg session ruby/irb@4029c2e564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
irb:rdbgsession, IRB should passhelpcommand to the debugger, instead of invoking ri.show_cmdsshould update its content when in theirb:rdbgsession:Debuggingsession as they're not useful in that context.helpdue to the change of 1)debug's help message at the end of its output, so users don't need to learn when to useshow_cmdsand when to usehelp.