Clear all context usages in RubyLex #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
remove-context-from-ruby-lex
branch
from
5025d5a
to
ebea5b8
Compare
st0012
force-pushed
the
remove-context-from-ruby-lex
branch
from
ebea5b8
to
343ac2b
Compare
tompng
reviewed
Oct 3, 2023
st0012
force-pushed
the
remove-context-from-ruby-lex
branch
from
343ac2b
to
4bdf0a0
Compare
After this change, `RubyLex` will not interact with `Context` directly in any way. This decoupling has a few benefits: - It makes `RubyLex` easier to test as it no longer has a dependency on `Context`. We can see this from the removal of `build_context` from `test_ruby_lex.rb`. - It will make `RubyLex` easier to understand as it will not be affected by state changes in `Context` objects. - It allows `RubyLex` to be used in places where `Context` is not available.
st0012
force-pushed
the
remove-context-from-ruby-lex
branch
from
4bdf0a0
to
e8e9841
Compare
tompng
approved these changes
Oct 4, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Oct 4, 2023
(ruby/irb#684) After this change, `RubyLex` will not interact with `Context` directly in any way. This decoupling has a few benefits: - It makes `RubyLex` easier to test as it no longer has a dependency on `Context`. We can see this from the removal of `build_context` from `test_ruby_lex.rb`. - It will make `RubyLex` easier to understand as it will not be affected by state changes in `Context` objects. - It allows `RubyLex` to be used in places where `Context` is not available. ruby/irb@d5b262a076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change,
RubyLexwill not interact withContextdirectly in any way. This decoupling has a few benefits:RubyLexeasier to test as it no longer has a dependency onContext. We can see this from the removal ofbuild_contextfromtest_ruby_lex.rb.RubyLexeasier to understand as it will not be affected by state changes inContextobjects.RubyLexto be used in places whereContextis not available.(This is based on #683 and needs it to be merged first)