Clear all context usages in RubyLex #684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change,
RubyLex
will not interact withContext
directly in any way. This decoupling has a few benefits:RubyLex
easier to test as it no longer has a dependency onContext
. We can see this from the removal ofbuild_context
fromtest_ruby_lex.rb
.RubyLex
easier to understand as it will not be affected by state changes inContext
objects.RubyLex
to be used in places whereContext
is not available.(This is based on #683 and needs it to be merged first)