Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history-saving feature #642

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix history-saving feature #642

merged 2 commits into from
Jul 14, 2023

Commits on Jul 13, 2023

  1. Define RelineInputMethod::HISTORY

    The HistorySavingAbility module doesn't do anything if the input method
    class doesn't define HISTORY.
    
    - https://github.com/ruby/irb/blob/3ac96be660bf052902fb4e532c7a46cf294b71eb/lib/irb/history.rb#L10
    - https://github.com/ruby/irb/blob/3ac96be660bf052902fb4e532c7a46cf294b71eb/lib/irb/history.rb#L34
    
    This patch defines RelineInputMethod::HISTORY to avoid this.
    st0012 committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    9e2bc35 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Improve history-saving's ability check

    Instead of checking the existence of `input_method_class::HISTORY`, we should
    make every input method class declare if it supports history saving or not.
    
    Since the default value is `false`, it shouldn't break any custom input method
    that inherits from `IRB::InputMethod`.
    st0012 committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    3d4b66c View commit details
    Browse the repository at this point in the history