Phantom types: Logical borders #552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just the one-liners with 1, 2 and 3-argument variants.
Adds implementations for the following: - border-block-start-color - border-block-end-color - border-inline-start-color - border-inline-end-color
Adds implementations for the following: - border-block-style - border-inline-style Also applies elm-format for this commit and the previous commits.
Implements the following: - border-block-start-style - border-block-end-style - border-inline-start-style - border-inline-end-style
Implements the following: - border-block-width - border-inline-width
Implements the following: - border-block-start-width - border-block-end-width - border-inline-start-width - border-inline-end-width
Implements the following: - border-block-start - border-block-end - border-inline-start - border-inline-end All in 1, 2 and 3-argument variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functions covering the following properties for the
phantom-typesbranch:(to my knowledge this covers all logical border properties apart from border-radius ones)
border-blockborder-block-colorborder-block-endborder-block-end-colorborder-block-end-styleborder-block-end-widthborder-block-startborder-block-start-colorborder-block-start-styleborder-block-start-widthborder-block-styleborder-block-widthborder-inlineborder-inline-colorborder-inline-endborder-inline-end-colorborder-inline-end-styleborder-inline-end-widthborder-inline-startborder-inline-start-colorborder-inline-start-styleborder-inline-start-widthborder-inline-styleborder-inline-widthImplementing them basically just involved a lot of repetition because they share identical arguments with similar border properties.