fix: extensionAlias should be a map (#15)

rspack-contrib · Sep 23, 2024 · 0fc9154 · 0fc9154
1 parent 8656bae
commit 0fc9154
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -553,11 +553,10 @@ config.resolve.extensions
 #### Config resolve extensionAlias
 
 ```js
-config.resolve.extensionAlias : ChainedSet
+config.resolve.extensionAlias : ChainedMap
 
 config.resolve.extensionAlias
-  .add(value)
-  .prepend(value)
+  .set(key, value)
   .clear()
 ```
 

diff --git a/src/Resolve.js b/src/Resolve.js
@@ -2,13 +2,12 @@ const ChainedMap = require('./ChainedMap');
 const ChainedSet = require('./ChainedSet');
 const Plugin = require('./Plugin');
 
-const childMaps = ['alias', 'fallback', 'byDependency'];
+const childMaps = ['alias', 'fallback', 'byDependency', 'extensionAlias'];
 const childSets = [
   'aliasFields',
   'conditionNames',
   'descriptionFiles',
   'extensions',
-  'extensionAlias',
   'mainFields',
   'mainFiles',
   'exportsFields',

diff --git a/test/Resolve.js b/test/Resolve.js
@@ -210,10 +210,13 @@ test('tsConfig object', () => {
 
 test('extensionAlias', () => {
   const resolve = new Resolve();
-  const instance = resolve.extensionAlias.add('.ts').add('.js').end();
+  const instance = resolve.extensionAlias
+    .set('.a', '.b')
+    .set('.b', ['.c', '.d'])
+    .end();
 
   expect(instance).toBe(resolve);
   expect(resolve.toConfig()).toStrictEqual({
-    extensionAlias: ['.ts', '.js'],
+    extensionAlias: { '.a': '.b', '.b': ['.c', '.d'] },
   });
 });
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -356,7 +356,7 @@ declare namespace Config {
       RspackResolve['descriptionFiles'][number]
     >;
     extensions: TypedChainedSet<this, RspackResolve['extensions'][number]>;
-    extensionAlias: TypedChainedSet<this, RspackResolve['extensionAlias'][number]>;
+    extensionAlias: TypedChainedMap<this, RspackResolve['extensionAlias']>;
     mainFields: TypedChainedSet<this, RspackResolve['mainFields'][number]>;
     mainFiles: TypedChainedSet<this, RspackResolve['mainFiles'][number]>;
     exportsFields: TypedChainedSet<

diff --git a/types/test/rspack-chain-tests.ts b/types/test/rspack-chain-tests.ts
@@ -183,6 +183,9 @@ config
   .end()
   .extensions.add('.js')
   .end()
+  .extensionAlias.set('a', 'b')
+  .set('b', ['c'])
+  .end()
   .mainFields.add('browser')
   .end()
   .mainFiles.add('index.js')