Remove usages of deprecated in ktor APIs #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 699 files ±0 699 suites ±0 31m 54s ⏱️ + 4m 51s For more details on these failures, see this check. Results for commit 67da0ee. ± Comparison against base commit 37315f8. ♻️ This comment has been updated with latest results. |
OlegDokuka
approved these changes
Feb 29, 2024
whyoleg
force-pushed
the
extract-internal-io
branch
from
37315f8
to
ce3426b
Compare
* introduce BufferPool as a placeholder for something that will (or will not) available after migration to ktor 3.0 and kotlinx-io
whyoleg
force-pushed
the
ktor-deprecation
branch
from
67da0ee
to
2ccd4c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChunkBufferand a lot of other things inktor-ioare deprecated for removal in favour ofkotlinx-ioin ktor 2.3.3 (actual version is 2.3.8).Still, at this point ktor itself doesn't provide any integration yet even in ktor 3.0 releases.
So this PR Introduces
BufferPoolas a placeholder for something that will (or will not) available after migration to ktor 3.0 and kotlinx-io.BufferPoolis used internally (in tests) to test for leaks.Depends on: #247, #244