Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #12

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Update setup.py #12

merged 1 commit into from
Nov 12, 2022

Conversation

Brainor
Copy link
Contributor

@Brainor Brainor commented Sep 16, 2022

While I trying to submit this package to conda-forge, the checks threw an error.
I guess it's about the encoding in reading file; according to document, the encoding used in Windows system is cp936 in China, not utf-8; but the README.md file contains emoji characters, which can't be read with cp936 encoding.
Could you please update the pypi package if it's OK with you? 😱

specify encodings in `open` function.
@Brainor
Copy link
Contributor Author

Brainor commented Sep 24, 2022

Hey, dear rsalmei, like I said in this issue before, conda-forge is a platform; what I will do is just submitting this package to conda-forge, you are still the maintainer to the conda-forge package repo (like this one), which is created by conda-forge, not by me.

@TheTechRobo
Copy link

@rsalmei ping

@Brainor Brainor closed this Nov 12, 2022
@rsalmei rsalmei merged commit c09904d into rsalmei:main Nov 12, 2022
@rsalmei
Copy link
Owner

rsalmei commented Nov 12, 2022

Sorry, I haven't seen this before. Merged.

@rsalmei
Copy link
Owner

rsalmei commented Nov 12, 2022

Oh, do I have to also publish it to PyPI @Brainor, or just merge it is enough?

@Brainor
Copy link
Contributor Author

Brainor commented Nov 12, 2022

Oh, it's OK now. I closed the PR because I used the patch in the conda-forge feedstock to modify the setup.py file, and it's succeesfully on the conda-forge channel today. (You can see it here.)
So you don't need to publish it to PyPI now.

If you are interested in maintaining the conda-forge package aside from the PyPI one, all you need to do is to become the maintainer of the about-time-feedstock repo . According to the manual, just opening an issue in the feedstock repository with the following title: @conda-forge-admin, please add user @rsalmei :) From what I know, the bot in conda-forge can automatically update conda-forge-about-time package if there is a update in PyPI-about-time package so you can totally leave it be.

I've also proposed the alive-progress package update in the PR waiting to be approved just so you know:)

@rsalmei
Copy link
Owner

rsalmei commented Nov 12, 2022

That's excellent, thank you 👍

I love messages like yours, full of links so one can go deeper if needed. I did enter them all, but I know nothing about conda, mamba, or feedstocks, so I think I'll let them to people like you, who knows what he is doing...

Thanks for the alive-progress one as well!

@Brainor
Copy link
Contributor Author

Brainor commented Nov 12, 2022

Oh thank you:)
Correct me if I'm wrong. Just like PyPI using pip install about-time to install package, you can use conda install about-time to install it; I'm sure you already know this. And many people (including me) think conda can manage environments and packages better than pypi but not too different from each other.
About-time-feedstock manages the about-time package used in conda system; it can adapt the about-time package from PyPI into the conda system automatically.

I'm also totally new to the feedstock thing, I just learn this stuff to make alive-progress's new version available in conda in the first place because alive-progress is really good lol
BTW, maybe you can update the alive-progress setup.py's about-time version to the newest in the next update now that about-time is 4.1 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants