Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from sandboxie-plus:master #313

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 30, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Copy link

sourcery-ai bot commented Sep 30, 2024

Reviewer's Guide by Sourcery

This pull request includes bug fixes and minor improvements to Sandboxie Plus. The main changes are:

  1. Fixed an issue with sandbox path entry combo boxes.
  2. Resolved a buffer overflow problem in the proxy for GetRawInputDeviceInfoW().
  3. Updated version numbers for a new release (1.14.10 / 5.69.10).
  4. Made improvements to the GetRawInputDeviceInfo implementation to handle different data types correctly.

Sequence Diagram

sequenceDiagram
    participant Client
    participant Gui_GetRawInputDeviceInfo_impl
    participant GuiServer
    participant Windows API
    Client->>Gui_GetRawInputDeviceInfo_impl: Call GetRawInputDeviceInfo
    Gui_GetRawInputDeviceInfo_impl->>GuiServer: Send request
    GuiServer->>Windows API: GetRawInputDeviceInfo
    Windows API-->>GuiServer: Return data
    GuiServer-->>Gui_GetRawInputDeviceInfo_impl: Send response
    Gui_GetRawInputDeviceInfo_impl-->>Client: Return result
Loading

File-Level Changes

Change Details Files
Fixed buffer overflow in GetRawInputDeviceInfoW proxy
  • Modified Gui_GetRawInputDeviceInfo_impl to handle different data types correctly
  • Updated GetRawInputDeviceInfoSlave to properly handle unicode and non-unicode requests
  • Added a new 'hasSize' field to the GUI_GET_RAW_INPUT_DEVICE_INFO_REQ struct
Sandboxie/core/dll/guimisc.c
Sandboxie/core/svc/GuiServer.cpp
Sandboxie/core/svc/GuiWire.h
Version number update for new release
  • Incremented version numbers to 1.14.10 / 5.69.10
  • Updated CHANGELOG.md with new version and fixes
CHANGELOG.md
Sandboxie/common/my_version.h
SandboxiePlus/version.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, pull[bot]!). We assume it knows what it's doing!

@pull pull bot added the ⤵️ pull label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants