Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow #73

Merged
merged 3 commits into from
Jul 23, 2023
Merged

Update workflow #73

merged 3 commits into from
Jul 23, 2023

Conversation

jannic
Copy link
Member

@jannic jannic commented Jun 6, 2023 •
edited
Loading

Update github workflows:

  • Run update.sh and check for changed files, so we notice if the generated files in src/ need to be updated
  • Run clippy with a fixed rust version (1.64 for now), so the checks don't break at random times when new clippy lints get added
  • Replace deprecated actions-rs actions

@jannic jannic marked this pull request as ready for review July 6, 2023 18:52
@ithinuel
Copy link
Member

ithinuel commented Jul 23, 2023 •
edited
Loading

In here I suggest that we remove the srcs from the main branch and have a pipeline/workflow to generate it on a dedicated branch ala github pages.

If you think this is a good idea, should we do it as part of this PR?

@jannic
Copy link
Member Author

jannic commented Jul 23, 2023

If you think this is a good idea, should we do it as part of this PR?

Let's keep the discussion separate. I opened #78

@jannic jannic merged commit a67ec9e into rp-rs:main Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ithinuel ithinuel ithinuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jannic @ithinuel