Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPI example using embedded_hal_bus #835

Merged
merged 7 commits into from
Sep 1, 2024
Merged

Add SPI example using embedded_hal_bus #835

merged 7 commits into from
Sep 1, 2024

Conversation

9names
Copy link
Member

@9names 9names commented Aug 19, 2024

No description provided.

thejpster
thejpster requested changes Aug 19, 2024
View reviewed changes
rp2040-hal-examples/src/bin/spi_eh_bus.rs Outdated Show resolved Hide resolved
rp2040-hal-examples/Cargo.toml Outdated Show resolved Hide resolved
rp2040-hal-examples/src/bin/spi_eh_bus.rs Outdated Show resolved Hide resolved
rp2040-hal-examples/src/bin/spi_eh_bus.rs Outdated Show resolved Hide resolved
rp2040-hal-examples/src/bin/spi_eh_bus.rs Outdated Show resolved Hide resolved
rp2040-hal-examples/src/bin/spi_eh_bus.rs Outdated Show resolved Hide resolved
@thejpster
Copy link
Member

I propose some extra comments/updates in https://github.com/rp-rs/rp-hal/tree/spibus_example.

@9names
Copy link
Member Author

9names commented Aug 20, 2024

Everything in your branch looks fine to me, going to cherry-pick it into here.
I think I'll add the pac->p rename on top though, it tidies up a bit of the initialisation code

@9names
Copy link
Member Author

9names commented Aug 20, 2024

We probably want a 2nd reviewer now that we've both had a hand in here

@9names 9names requested a review from jannic August 20, 2024 11:52
@thejpster thejpster merged commit 512b102 into rp-rs:main Sep 1, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejpster thejpster thejpster approved these changes

@jannic jannic jannic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@9names @thejpster @jannic