Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://doc.rust-lang.org/stable/reference/inline-assembly.html#directives-support the assembly directive
.macro
is not part of the supported subset.The reference further explains: "The result of using other directives is assembler-specific (and may cause an error, or may be accepted as-is)"
So while it obviously works right now, it might cause issues in future versions of rust. Not sure if this would be avoided as a breaking change. To be on the safe side, replace asm macros by rust macros.