Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of MPU RBAR value #653

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix calculation of MPU RBAR value #653

merged 1 commit into from
Jul 20, 2023

Conversation

jannic
Copy link
Member

@jannic jannic commented Jul 19, 2023

See raspberrypi/pico-sdk#993 for an explanation why the old code happens to work in practice, due to the reset value of the register.

Thanks to @9names for mentioning this issue in the pico-sdk repo.

Fixes #641

See raspberrypi/pico-sdk#993 for an
explanation why the old code happens to work in practice, due to the
reset value of the register.

Thanks to @9names for mentioning this issue in the pico-sdk repo.

Fixes rp-rs#641
Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannic jannic merged commit 8a0b9fc into rp-rs:main Jul 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arithmetic mistake setting up core1 stack protection
2 participants