Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User shortName instead of substring on sha copy #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mczepiel
Copy link

Nothing functionally different, just using what the commit offers. In the process of some other changes locally.

@mczepiel
Copy link
Author

FWIW it looks like shortName will always return a SHA, so this is functionally equivalent to the manual substring:

- (NSString *) shortName
{
    return self.gtCommit.shortSHA;
}

So this should be fine so long as we're alwasy dealing with commits and not refs, which have a different shortName behavior:
// shortName a more user friendly version of the refName, "master" or a short SHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant