window size and pane position reverts

[garyfoster]

After upgrading from 0.15.1949 to 0.15.1964, the size and position of the main application window will revert to a much smaller size on subsequent opens of the app. And if I adjust the pane position between the top section and the bottom section, that position reverts as well. I have to adjust these positions every time I open the app in order to use it. I'm on OS X Yosemite.

[dbackeus]

+1

[ghost]

I tried to investigate this a bit. I didn't have much success but here is what I found:

• The frames are saved correctly in the user defaults
• The first window opened after launching the app will have the correct frame, all the subsequent ones will have the smaller incorrect one
• Windows that were open when closing the app will be restored correctly

No clue yet on where the incorrect frame is coming from, it seems to be already wrong in awakeFromNib.

[kemenaran]

+1, I have this issue too, and can't see in the commit log where it broke.

[ghost]

This was introduced by e546301. Investigating.

[ghost]

If anyone trusts me and wants to test my fixes I uploaded a build here http://cl.ly/YVDz/download/GitX-dev-1964b.dmg

[kemenaran]

I just tested this build: it looks good to me, and fixes the window size issue.

[kegan]

+1

[jacobsvante]

I can confirm that @ghost's fix works. Maybe create a PR for it?

[ghost]

It's already a PR.

[jacobsvante]

Okay sorry, couldn't find it though (and I still can't)

[ghost]

I should have mentioned it. The fix for this issue and a couple other regressions is #405.

[ulope]

I'm sorry to nag but it's incredibly annoying having to resize the window and dividers inside it every single time I use GitX.

Is there any ETA for a new release?

[jacobsvante]

Any news here? This is really frustrating and leaves a bitter after-taste from using the app.

[dmishe]

This started happening to me after the upgrade to 10.10, 10.9 worked just fine.

[jacobsvante]

So quiet in here :(

[emptyflask]

+1!

[jdbeutel]

I've been using ghost's 1964b for a while, now on OS X 10.10.4, and it's been working fine. So, I hope that his PR on #405 will be merged in, so I can go back to the main release.

[beporter]

Sometimes it can be prudent not to assume that maintainers are always notified of new activity. The flood of emails can be overwhelming, so sometimes it's worth directly mentioning them (very politely and sparingly). For example:

Hey @rowanj, this thread's been waiting for attention for a few months now and the associated PR looks like it could help some people out. Could you spare a few minute to look things over when you have a chance?