Update action to work with user/organization sites #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rossjrw do you need me to make this change from not-a-fork and resubmit? Saw the CI failed. |
|
@ENG-Jole thanks for your contribution - I'll take a look when I get a chance! The CI has failed because the preview system doesn't currently support previews for forks, which I'm working on fixing (see #3) - unfortunately I've recently started a new job and haven't found much time to properly resume work on it. Your changes are probably fine; I'll just test them locally. (There's no way you could contribute changes without forking, as only I currently have write access to this repository). |
|
@rossjrw no worries! Thanks for your hard work making this, absolute lifesaver 😊 |
chadoh
added a commit
to AhaLabs/ahalabs.github.io
that referenced
this pull request
Aug 8, 2022
Uses fix from rossjrw/pr-preview-action#11, which respects user/organization sites
|
Hope this merge soon |
aidanheerdegen
pushed a commit
to ACCESS-NRI/pr-preview-action
that referenced
this pull request
Oct 25, 2022
Update action to work with user/organization sites
aidanheerdegen
pushed a commit
to ACCESS-NRI/pr-preview-action
that referenced
this pull request
Oct 25, 2022
Update action to work with user/organization sites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rossjrw This action currently does not work with organization or user sites. Since the format for user/org sites is different from project sites, it will attempt to deploy to ORG_NAME.github.io/ORG_NAME.github.io/UMBRELLA_FOLDER which just redirects to ORG_NAME.github.io. I added some logic to check whether the repo belongs to an org/user site & create the pagesurl var accordingly. Otherwise it will use the current sed command to create the pagesurl var.