Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sros2 tests on Windows Debug. #317

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix sros2 tests on Windows Debug. #317

merged 1 commit into from
May 23, 2024

Commits on May 22, 2024

  1. Fix sros2 tests on Windows Debug. 

    From what I can tell, it looks like lxml has a bug
where it doesn't properly track references to objects
via the find() method.  This manifests on Windows debug
as a crash *after* we have stopped using the object, but
I believe that by that point the underlying memory has
already been freed.  Windows Debug in particular is sensitive
to this.

Fix it by doing a deepcopy of the object returned from the
find().  This code isn't performance sensitive, so it shouldn't
be a big deal to do it here, and it fixes the bug in my testing.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed May 22, 2024
    Configuration menu
    Copy the full SHA
    4f136df View commit details
    Browse the repository at this point in the history