Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-daemon and --spin-time explanation in readme. (backport #307) #308

Merged
merged 1 commit into from
May 8, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 8, 2024

address part of #306


This is an automatic backport of pull request #307 done by Mergify.

* add `--no-daemon` and `--spin-time` explanation in readme.
* increase `--spin-time` from 3 to 4 seconds based on CI.

---------

Signed-off-by: Tomoya Fujita <[email protected]>
(cherry picked from commit 1a4257d)
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

@mikaelarguedas
Copy link
Member

Taking the ROS 2 buildfarm CI result on this one (the github action workflow changes are being updated only on rolling for now and will not work on jazzy before a little bie)

Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, doc only change

@mikaelarguedas mikaelarguedas merged commit 2b0da72 into jazzy May 8, 2024
3 of 7 checks passed
@mikaelarguedas mikaelarguedas deleted the mergify/bp/jazzy/pr-307 branch May 8, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants