add back codecov.yml config #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rolling #303 +/- ##
========================================
Coverage 77.35% 77.35%
========================================
Files 25 25
Lines 627 627
Branches 66 66
========================================
Hits 485 485
Misses 121 121
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mikael Arguedas <[email protected]>
ahcorde
approved these changes
May 8, 2024
Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
fix_codecov_path
branch
from
c18f2f2
to
ce7d191
Compare
Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
fix_codecov_path
branch
from
c63a700
to
48617c1
Compare
Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
fix_codecov_path
branch
from
33e8aa6
to
ed41786
Compare
Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
fix_codecov_path
branch
from
e8ae716
to
61d6b03
Compare
This reverts commit ed41786. Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
fix_codecov_path
branch
from
d81fb6f
to
8093d78
Compare
|
@ahcorde @fujitatomoya thanks for the reviews! The only change I made since your review was that I adjusted the path rewriting in the codecov.yml file This seems to now work as expected, we'll be sure only once we get coverage on rolling with that change and PRs coming in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll back #185
Using new
codecov_yml_pathargument: https://github.com/codecov/codecov-action?tab=readme-ov-file#argumentsThis should fix coverage visualization on codecov.io