Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] rolling is now the default branch, update CI and README accordingly #299

Merged
merged 7 commits into from
May 7, 2024

Conversation

mikaelarguedas
Copy link
Member

Also bumps runner to ubuntu-latest but doesnt matter as everything runs in containers

This is an attempt to revive CI that has been off for a long time

Warning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).

Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
This reverts commit b6a6f7a.

Signed-off-by: Mikael Arguedas <[email protected]>
@mikaelarguedas mikaelarguedas marked this pull request as ready for review May 7, 2024 00:40
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikaelarguedas thanks for the PR.

as you mentioned, runs-on does not really matter, since container is used anyway. (just fyi, https://github.com/actions/runner-images?tab=readme-ov-file#available-images, ubuntu-latest is still ubuntu 22.04.)

and nightly build looks good to me, but we do not have any CI for iron and humble? i did not really know the history for sros2 CI...

@mikaelarguedas
Copy link
Member Author

mikaelarguedas commented May 7, 2024

and nightly build looks good to me, but we do not have any CI for iron and humble? i did not really know the history for sros2 CI...

my feeling is that this workflow has 2 main goals ->

  • test_latest: generate coverage on pull requests and merges
  • test_nightly: catch any regression overnight

for released distros I believe we can keep relying on the PR jobs of the ROS buildfarm 👍

@mikaelarguedas
Copy link
Member Author

I'll get this in as-is and work on gettign latest back to working in a separate PR

@mikaelarguedas mikaelarguedas merged commit 335bcae into rolling May 7, 2024
5 checks passed
@mikaelarguedas mikaelarguedas deleted the fixup_ci branch May 7, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants