Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add return code to all verb apis #28

Merged
merged 1 commit into from
Feb 22, 2018
Merged

add return code to all verb apis #28

merged 1 commit into from
Feb 22, 2018

Conversation

mikaelarguedas
Copy link
Member

@mikaelarguedas mikaelarguedas commented Nov 15, 2017 •
edited
Loading

WIP: will be needed to access_control testing

Connects to ros2/system_tests#238

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Nov 15, 2017
@mikaelarguedas mikaelarguedas self-assigned this Nov 22, 2017
@mikaelarguedas
Copy link
Member Author

This improvement doesnt need the ccess control tests to be ready to be merged, placing it in review

@mikaelarguedas mikaelarguedas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 22, 2018
@mikaelarguedas mikaelarguedas merged commit c10858e into master Feb 22, 2018
@mikaelarguedas mikaelarguedas deleted the missing_return branch February 22, 2018 20:12
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@mikaelarguedas mikaelarguedas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikaelarguedas @dirk-thomas