[iron] Fix for regression in open_succeeds_twice and minimal_writer_example tests (backport #1667)

[mergify]

• This PR fixes tests regression introduced in the Bugfix for writer not being able to open again after closing #1599
• Follow up from the Buildfarmer log 2024/05/20 - 2024/05/27 osrf/buildfarm-tools#53 (comment)

The error message from CI reference build:

/home/jenkins-agent/workspace/nightly_linux-aarch64_repeated/ws/src/ros2/rosbag2/rosbag2_compression/test/rosbag2_compression/test_sequential_compression_writer.cpp:242
Expected: writer_->open(storage_options, {serialization_format_, serialization_format_}) doesn't throw an exception.
  Actual: it throws std::runtime_error with description "Bag directory already exists (/tmp/path_not_empty), can't overwrite existing bag

• This PR addresses the failure in the rosbag2_compression.SequentialCompressionWriterTest.open_succeeds_twice on a second run due to the leftovers in the temp folder.
  It also addresses the flakiness in TestRosbag2CPPAPI::minimal_writer_example due to using shared ptr to the serialized message twice in the writer.write(msg) call.
  Note. The "serialized_msg2" in the TestRosbag2CPPAPI::minimal_writer_example does not own the serialized data after the first call writer.write(serialized_msg2,..). i.e. need to use another message or another API in the test for the second call to the writer.write(msg).

  ---

  This is an automatic backport of pull request Fix for regression in open_succeeds_twice and minimal_writer_example tests #1667 done by Mergify.

[mergify]

Cherry-pick of 8523995 has failed:

On branch mergify/bp/iron/pr-1667
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 8523995b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rosbag2_tests/test/rosbag2_tests/test_rosbag2_cpp_api.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rosbag2_compression/test/rosbag2_compression/test_sequential_compression_writer.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[MichaelOrlov]

Pulls: #1669
Gist: https://gist.githubusercontent.com/MichaelOrlov/bc10c58d4968ea164f392b6877f0d2af/raw/bd3bec476e142e94a00a027da603319f1b6d72e2/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_compression rosbag2_tests
TEST args: --packages-above rosbag2_compression rosbag2_tests
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/13941

• Linux
• Linux-aarch64
• Windows